Skip to content

fix: add snackbar for empty logged data #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcnause merged 8 commits into from
Apr 12, 2026
Merged

fix: add snackbar for empty logged data #3162

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5424a83
Add snackbar for empty logged data
Diksha-MukherjeeAgarwal Apr 2, 2026
4ed2890
Fix indentation in logged_data_screen.dart
Diksha-MukherjeeAgarwal Apr 2, 2026
f4057ec
Fix indentation in line 116
Diksha-MukherjeeAgarwal Apr 2, 2026
13c1494
Add loading check guard clause
Diksha-MukherjeeAgarwal Apr 12, 2026
c59c873
Fix return statement formatting in _deleteAllFiles
Diksha-MukherjeeAgarwal Apr 12, 2026
c478373
Fix return in line 106 statement formatting
Diksha-MukherjeeAgarwal Apr 12, 2026
e5c3b91
Fix one trailing space after return statement in 106
Diksha-MukherjeeAgarwal Apr 12, 2026
8e41cbf
Fix indentation
Diksha-MukherjeeAgarwal Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/view/logged_data_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,21 @@ class _LoggedDataScreenState extends State<LoggedDataScreen> {
}

Future<void> _deleteAllFiles() async {
if (_isLoading) {
return;
}
if (_files.isEmpty) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
appLocalizations.noLoggedData,
style: TextStyle(color: snackBarContentColor),
),
backgroundColor: snackBarBackgroundColor,
),
);
return;
}
Comment on lines +108 to +119

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _files.isEmpty early-return can be triggered while _loadFiles() is still in progress because _loadFiles() clears _files and sets _isLoading = true. Since the options menu is still available during loading, tapping “Delete All Data” immediately after opening the screen will incorrectly show the “No logged data” snackbar even if files exist.

Consider also guarding on _isLoading (e.g., return early or disable the menu action while loading) so the snackbar only appears when the empty state is final, not transient during refresh/loading.

Copilot uses AI. Check for mistakes.

@marcnause marcnause Apr 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Diksha-MukherjeeAgarwal, could you please have a look at the Copilot comment and apply the changes if you think they make sense?

final confirmed = await showDialog<bool>(
context: context,
builder: (BuildContext context) {
Expand Down
Loading