Skip to content

fix: screen to choice the hardware#3231

Draft
ctrlVnt wants to merge 6 commits into
fossasia:mainfrom
ctrlVnt:new-homescreen
Draft

fix: screen to choice the hardware#3231
ctrlVnt wants to merge 6 commits into
fossasia:mainfrom
ctrlVnt:new-homescreen

Conversation

@ctrlVnt

@ctrlVnt ctrlVnt commented May 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #3229

Changes

  • Added a new screen to choice the hardware
  • Edit AppBar to change hardware in instruments screen
  • Edit main to go in hardware choice screen if it was not already selected, in instruments otherwise
  • Added strings variables in English only
  • If we want to add or change which intruments we want to show we just need to edit instruments_screen.dart file

Screenshots / Recordings

Screencast.From.2026-05-12.16-38-04.webm

Checklist:

  • No hard coding: I have used values from constants.dart or localization files instead of hard-coded values.
  • No end of file edits: No modifications done at end of resource files.
  • Code reformatting: I have formatted the code using dart format or the IDE formatter.
  • Code analysis: My code passes checks run in flutter analyze and tests run in flutter test.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @ctrlVnt, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@rahul31124

Copy link
Copy Markdown
Member

Hello @ctrlVnt , I feel this is not needed at the moment, or it may be a bit too early. We can discuss this properly first and then implement it.

@marcnause marcnause changed the title Fix: screen to choice the hardware fix: screen to choice the hardware May 14, 2026
@ctrlVnt ctrlVnt marked this pull request as draft May 17, 2026 16:52
@ctrlVnt

ctrlVnt commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

I draft this PR for the future, too early

@bhavjsh bhavjsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlVnt Good idea for future but for now I agree with Rahul's comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] New main screen to choice the hardware for the first time

5 participants