Skip to content

fix: add error handling for launchUrl in About Us feedback link #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcnause merged 3 commits into from
Jul 1, 2026
Merged

fix: add error handling for launchUrl in About Us feedback link #3382

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8c6534
fix: add error handling for launchUrl in About Us feedback link
prajakta128 Jun 30, 2026
b3712c6
refactor: use logger instead of debugPrint for launchUrl failure
prajakta128 Jun 30, 2026
2ec43dc
fix: restore correct URL handling and logger calls in about_us_screen
prajakta128 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/view/about_us_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Widget buildContactList(List<Map<String, dynamic>> items) {
if (await canLaunchUrl(uri)) {
await launchUrl(uri);
} else {
debugPrint('Could not launch ${item['url']}');
logger.e('Could not launch URL: ${item['url']}');
}
},
);
Expand Down Expand Up @@ -135,7 +135,14 @@ class _AboutUsScreenState extends State<AboutUsScreen> {
style: const TextStyle(fontSize: 15),
),
onTap: () async {
await launchUrl(Uri.parse(appLocalizations.feedbackForm));
final uri = Uri.parse(appLocalizations.feedbackForm);
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
if (await canLaunchUrl(uri)) {
await launchUrl(uri);
} else {
logger.e(
'Could not launch feedback form URL: ${appLocalizations.feedbackForm}',
);
}
},
),
const Divider(thickness: 0.5),
Expand All @@ -162,7 +169,8 @@ class _AboutUsScreenState extends State<AboutUsScreen> {
);
} else if (snapshot.hasError) {
logger.e(
"Error getting version information: ${snapshot.error.toString()}");
"Error getting version information: ${snapshot.error.toString()}",
);
return Text(
appLocalizations.error,
style: const TextStyle(fontSize: 15),
Expand Down
Loading