fix: Release mobile stores independently - #3567
shrutikbalwan wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe release workflow now validates the release version code in a shared job. Separate Android and iOS jobs prepare secrets, update fastlane metadata, and promote each platform release. ChangesRelease workflow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow
participant ReleaseAsset
participant AndroidFastlane
participant IOSFastlane
ReleaseWorkflow->>ReleaseAsset: Download versionCode.txt for RELEASE_TAG
ReleaseAsset-->>ReleaseWorkflow: Return numeric version code
ReleaseWorkflow->>ReleaseWorkflow: Expose VERSION_CODE
ReleaseWorkflow->>AndroidFastlane: Update metadata and promote Android release
ReleaseWorkflow->>IOSFastlane: Update metadata and promote iOS release
Merge Risk: ⚪ Minimal · up to The independent Android and iOS promotion jobs retain the shared release values needed for their metadata updates and promotions. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideRestructures the release workflow into a common metadata job plus independent Android and iOS promotion jobs, isolating credentials and Git setup per platform while safely propagating release metadata and correcting the iOS path. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the shared version or either store-specific release step is wrong, this workflow can publish an incorrect mobile release and force-push release metadata using production credentials. Reverting the workflow prevents future releases but does not unpublish a store release or restore the overwritten branch.
|
@marcnause, the iPhone screenshot job exceeded its 30-minute limit. The log reports All platform build jobs and the Android/iPad screenshot jobs passed. This PR changes the production release workflow only; it does not change app code or the screenshot workflow. I attempted a targeted rerun, but GitHub returned |
c4b867a to
1990b4e
Compare
6aad2d3 to
4ce221d
Compare
4ce221d to
8ee2499
Compare
Related to #3349 (partial implementation)
Change
An Android signing or production-promotion failure currently prevents iOS promotion because both run sequentially in one job. Read the release version in a common job, then run Android and iOS release jobs independently. Each job prepares its own credentials and Git identity.
Use the actual lowercase
iospath and pass release notes through an environment variable so quotes and shell syntax in release text are preserved as text.This addresses store-promotion independence only. Publishing the shared binary download branch still requires a maintainer decision about partial builds and stale artifacts. The broader issue remains open.
Validation
Coordination
@marcnause, this draft covers store-promotion isolation only. It leaves the shared binary publication policy unchanged pending the decision in the issue.
Screenshots / Recordings
N/A: workflow change.
Summary by Sourcery
Separate Android and iOS store release workflows while sharing validated release version information.
Bug Fixes:
Enhancements:
CI validation update
GitHub Actions run.
Passed: Codacy Static Code Analysis, macOS Flutter Build, Windows Flutter Build, Linux Flutter Build, Android Flutter Build, Screenshots (Android), Linux ARM64 Flutter Build, iOS Flutter Build, Screenshots (iPad), Web App Flutter Build, Validate PR title, Common Build, Detect Changes.
The iPhone screenshot job later exceeded its 30-minute timeout. A targeted rerun requires repository admin rights; diagnosis and maintainer rerun request.
Ready for review of the stated scope. Remaining manual checks and broader issue work above are not claimed complete.
Summary by CodeRabbit
Bug Fixes
Chores