Skip to content

chore: replace discontinued dependency - #3621

Merged
marcnause merged 1 commit into
fossasia:mainfrom
marcnause:updateGaugeDependency
Oct 3, 2026
Merged

marcnause merged 1 commit into
fossasia:mainfrom
marcnause:updateGaugeDependency

Conversation

@marcnause

@marcnause marcnause commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #3620

Changes

  • replaced discontinued library with successor

Screenshots / Recordings

N/A (no visible changes)

Checklist:

  • No hard coding: I have used values from constants.dart or localization files instead of hard-coded values.
  • No end of file edits: No modifications done at end of resource files.
  • Code reformatting: I have formatted the code using dart format or the IDE formatter.
  • Code analysis: My code passes checks run in flutter analyze and tests run in flutter test.

Summary by Sourcery

Replace the discontinued gauge library with its supported successor.

Enhancements:

  • Replace the discontinued gauge dependency with its successor while preserving the instrument gauge’s existing presentation and behavior.

Build:

  • Update project dependencies and lockfile to use gx_gauge instead of girix_code_gauge.

Summary by CodeRabbit

  • Improvements
    • Updated the instrument gauge’s rendering while preserving its displayed values, angles, tick styling, and overall presentation. The gauge continues to show the same information and retain its established visual configuration; no changes to its available settings or displayed content are noted.

@marcnause
marcnause requested review from CloudyPadmal and a balanced review from Copilot October 3, 2026 21:11
@sourcery-ai

sourcery-ai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes the discontinued girix_code_gauge dependency, adds gx_gauge, and updates InstrumentGauge to use the successor’s renamed types and revised constructor parameters while preserving the existing gauge configuration and appearance.

File-Level Changes

Change Details Files
Replace the discontinued gauge package with its successor and adapt the gauge widget to the successor API.
  • Swap the package dependency and import.
  • Rename gauge value, style, needle, tick, and enum types to the successor equivalents.
  • Map API differences for diameter, numeric interval, needle cap, and corrected tapered-line shape.
lib/view/widgets/gauge_widget.dart
pubspec.yaml
pubspec.lock

Assessment against linked issues

Issue Objective Addressed Explanation
#3620 Replace the discontinued girix_code_gauge dependency with its successor gx_gauge. ✅
#3620 Update the gauge widget to use the gx_gauge package and its corresponding API so the project continues to build and function correctly. ✅
#3620 Update the package dependency metadata and lockfile to reflect the replacement dependency. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dd3f17de-2ad1-4db0-a1c2-60463b733f13
📥 Commits

Reviewing files that changed from the base of the PR and between f3c7503 and ffda863.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • lib/view/widgets/gauge_widget.dart
  • pubspec.yaml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The gauge widget now uses the gx_gauge package. Its radial gauge and needle configuration use the package’s API, and pubspec.yaml replaces the girix_code_gauge dependency.

Changes

Gauge dependency migration

Layer / File(s) Summary
Migrate gauge widget to gx_gauge
lib/view/widgets/gauge_widget.dart, pubspec.yaml
The widget uses gx_gauge radial gauge and needle types. The configuration retains the existing value bounds, angles, labels, and tick styling. The dependency changes from girix_code_gauge to gx_gauge ^1.0.1.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to ffda8

The PR swaps the gauge renderer, and dependency resolution is aligned. Available evidence does not establish a user-visible regression or an actionable merge blocker.

Security Architecture Review

Security architecture risk: 🔵 Low · up to ffda8

The application-level changes retain the gauge’s inputs, value clamping, and presentation-only role. No new security boundary crossing was identified in that code. The replacement library’s internal behavior has not been verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The demonstrated integration scope is gauge rendering within the client application. The supplied consumer passes sensor-display values and scale settings. This bounds the observed application flow, not the replacement package’s possible internal access or behavior.

Trust Boundaries and Controls

  • observed — The application retains its numeric clamping before rendering. This is a display-range control, not an access-control or sandbox boundary; inspection found no application-level authority transition added by the migration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: replacing the discontinued gauge dependency with its successor.
Linked Issues check ✅ Passed Issue #3620 requests replacing the discontinued girix_code_gauge package with gx_gauge. pubspec.yaml replaces the dependency with gx_gauge version ^1.0.1, and gauge_widget.dart migrates `I…
Out of Scope Changes check ✅ Passed The reported changes update the gauge dependency and migrate its widget usage. Both changes directly support issue #3620. No unrelated change is identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 2 Low severity

Open (2)
What changed in this PR

Replaces the discontinued girix_code_gauge dependency with its successor gx_gauge and updates the gauge widget implementation accordingly.

Changes:

  • Swapped dependency from girix_code_gauge to gx_gauge in pubspec.yaml and pubspec.lock
  • Migrated InstrumentGauge usage from the old gauge API/types to gx_gauge equivalents
File Description
pubspec.yaml Replaces discontinued direct dependency with gx_gauge.
pubspec.lock Updates lockfile to remove girix_code_gauge and add gx_gauge.
lib/​view/​widgets/​gauge_widget.dart Migrates gauge widget code to the new gx_gauge API.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/view/widgets/gauge_widget.dart
Comment thread lib/view/widgets/gauge_widget.dart
@marcnause
marcnause enabled auto-merge (rebase) October 3, 2026 21:36
@marcnause
marcnause merged commit 0a1449d into fossasia:main Oct 3, 2026
17 of 18 checks passed
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Build Status: Build successful.

Build artifacts to test

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

@marcnause
marcnause deleted the updateGaugeDependency branch October 4, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency girix_code_gauge is discontinued

2 participants