-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increased UART Read Timeout #186
Conversation
Reviewer's Guide by SourceryThe UART read timeout has been increased from 1ms to 100ms to address timing issues introduced by recent Flutter architectural changes. The timeout variable type was changed to No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the timeout is defined in terms of
FCY
. - Casting
FCY
to an unsigned long (UL
) is good practice to avoid potential overflow issues.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
208e3b0
to
73bc9ab
Compare
@bessman Strangely, the commit HASH is still different. |
Ah, right, that commit is on top of 6b6ce08, which we don't want in main. Then the hashes can't be the same, indeed. Then we'll merge as is. |
Increases the UART Read timeout to 100ms in our main firmware.
@bessman With the rolling out of flutter 3.29, there have been quite some architectural changes, on how dart code is executed on Android and iOS.
One of them is execution of dart code on the main thread of the running application (which makes it a tiny bit slower, but slow enough to take slightly more than 1ms to transfer the command to the board, especially in debug mode).
In order to keep our app stable in flutter, we would most definitely require a timeout increase.
Summary by Sourcery
Bug Fixes: