Skip to content

Add informational message when repository filtering is disabled #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gurusatsangi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add informational message when repository filtering is disabled #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,13 @@ <h4 class="font-semibold text-xl" data-i18n="noteTitle">Note:</h4>
<span data-i18n="tokenRequiredWarning">A GitHub token is required for repository
filtering. Please add one in the settings.</span>
</div>
<div id="filterDisabledMessage"
class="hidden text-xs text-blue-700 bg-blue-50 border border-blue-200 rounded-xl p-2 mt-2 flex items-center gap-2">

<i class="fa fa-info-circle"></i>
<span>Filtering is disabled. All repositories are included.</span>

</div>

<div id="repoFilterContainer" class="hidden">
<input id="repoSearch" type="text" data-i18n-placeholder="repoSearchPlaceholder"
Expand Down
16 changes: 16 additions & 0 deletions src/scripts/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,15 @@ document.addEventListener('DOMContentLoaded', () => {
useRepoFilter.checked = items.useRepoFilter;
repoFilterContainer.classList.toggle('hidden', !items.useRepoFilter);
}
const disabledMsg = document.getElementById('filterDisabledMessage');

if (disabledMsg) {
if (!items.useRepoFilter) {
disabledMsg.classList.remove('hidden');
} else {
disabledMsg.classList.add('hidden');
}
}
});

useRepoFilter.addEventListener(
Expand All @@ -1178,6 +1187,13 @@ document.addEventListener('DOMContentLoaded', () => {
const enabled = useRepoFilter.checked;
const hasToken = githubTokenInput.value.trim() !== '';
repoFilterContainer.classList.toggle('hidden', !enabled);
const disabledMsg = document.getElementById('filterDisabledMessage');

if (!enabled) {
disabledMsg.classList.remove('hidden');
} else {
disabledMsg.classList.add('hidden');
}
Comment thread
sourcery-ai[bot] marked this conversation as resolved.

if (enabled && !hasToken) {
useRepoFilter.checked = false;
Expand Down
Loading