Skip to content

fix: remove duplicate type attribute on script tag#550

Open
PhilixTheExplorer wants to merge 1 commit intofossasia:mainfrom
PhilixTheExplorer:fix/duplicate-script-type
Open

fix: remove duplicate type attribute on script tag#550
PhilixTheExplorer wants to merge 1 commit intofossasia:mainfrom
PhilixTheExplorer:fix/duplicate-script-type

Conversation

@PhilixTheExplorer
Copy link
Copy Markdown

@PhilixTheExplorer PhilixTheExplorer commented Apr 14, 2026

📌 Fixes

Fixes #549


📝 Summary of Changes

  • Removed the duplicate type="text/javascript" attribute from the <script> tag importing materialize.min.js in src/popup.html.
  • This resolves a minor HTML validation issue caused by invalid attribute duplication.

📸 Screenshots / Demo (if UI-related)

N/A - This is an internal HTML syntax fix and does not affect the UI.


✅ Checklist

  • I’ve tested my changes locally
  • I’ve added tests (if applicable)
  • I’ve updated documentation (if applicable)
  • My code follows the project’s code style guidelines

👀 Reviewer Notes

A straightforward HTML cleanup to ensure standard compliance. No functional changes to the extension.

Summary by Sourcery

Bug Fixes:

  • Resolve an HTML validation issue caused by a duplicated type attribute on the Materialize script tag in the popup.

Copilot AI review requested due to automatic review settings April 14, 2026 14:56
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes a duplicated type attribute from a script tag in popup.html to clean up HTML and resolve a minor validation issue without changing runtime behavior.

File-Level Changes

Change Details Files
Clean up the materialize.min.js script tag to remove duplicate type attribute and ensure valid HTML.
  • Updated the script tag that loads materialize.min.js to specify the type attribute only once
  • Ensured no functional changes by preserving src and remaining attributes as-is
src/popup.html

Assessment against linked issues

Issue Objective Addressed Explanation
#549 Remove the duplicate type="text/javascript" attribute from the <script> tag importing materialize.min.js in src/popup.html, so that the tag has at most one type attribute and is valid HTML.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an invalid duplicate type attribute from the materialize.min.js <script> tag in the extension’s popup HTML, addressing HTML validation for the popup page.

Changes:

  • Deleted the duplicated type="text/javascript" attribute on the Materialize script include in src/popup.html.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Duplicate type attribute on script tag in popup.html

2 participants