fix: remove duplicate type attribute on script tag#550
Open
PhilixTheExplorer wants to merge 1 commit intofossasia:mainfrom
Open
fix: remove duplicate type attribute on script tag#550PhilixTheExplorer wants to merge 1 commit intofossasia:mainfrom
PhilixTheExplorer wants to merge 1 commit intofossasia:mainfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves a duplicated type attribute from a script tag in popup.html to clean up HTML and resolve a minor validation issue without changing runtime behavior. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an invalid duplicate type attribute from the materialize.min.js <script> tag in the extension’s popup HTML, addressing HTML validation for the popup page.
Changes:
- Deleted the duplicated
type="text/javascript"attribute on the Materialize script include insrc/popup.html.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Fixes
Fixes #549
📝 Summary of Changes
type="text/javascript"attribute from the<script>tag importingmaterialize.min.jsinsrc/popup.html.📸 Screenshots / Demo (if UI-related)
N/A - This is an internal HTML syntax fix and does not affect the UI.
✅ Checklist
👀 Reviewer Notes
A straightforward HTML cleanup to ensure standard compliance. No functional changes to the extension.
Summary by Sourcery
Bug Fixes: