Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the advanced filters summary label styling to inherit text color, ensuring it adapts correctly in dark mode. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the summary text now inherits color for dark mode, consider updating the chevron icon (
text-gray-500) to also use an inherited or theme-aware color so the disclosure control looks consistent across themes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the summary text now inherits color for dark mode, consider updating the chevron icon (`text-gray-500`) to also use an inherited or theme-aware color so the disclosure control looks consistent across themes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Fixes the “Advanced Filters” label text color when dark mode is enabled in the popup UI (Issue #559) by removing the hardcoded light-mode text color on the <summary> element so it can follow the dark-mode styling.
Changes:
- Updated the Advanced Filters
<summary>text color class fromtext-gray-800totext-inheritinsrc/popup.html.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <details class="group mb-4" style="margin-top: 1rem;"> | ||
| <summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm text-gray-800 outline-none select-none pr-1"> | ||
| <summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm text-inherit outline-none select-none pr-1"> |
There was a problem hiding this comment.
text-inherit is not present in the shipped src/tailwindcss.css, so this utility class has no effect and is effectively dead code. Since the actual fix here is removing the hardcoded text-gray-800 (so the <summary> can inherit the .dark-mode text color), consider dropping text-inherit entirely, or regenerate/update tailwindcss.css so text-inherit (and any other new utilities) are included.
| <summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm text-inherit outline-none select-none pr-1"> | |
| <summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm outline-none select-none pr-1"> |
|
@mariobehling @vedansh-5 While this is not a critical issue, it does impact the user experience. If the advanced filter text becomes invisible in dark mode, users will struggle to use the feature. Please review and merge the fix at your earliest convenience. |
📌 Fixes
Fixes #559
📝 Summary of Changes
just add the tailwind class for dark mode
📸 Screenshots / Demo (if UI-related)
Before


After
✅ Checklist
[x] I’ve tested my changes locally
[x] My code follows the project’s code style guidelines
👀 Reviewer Notes
Summary by Sourcery
Bug Fixes: