Skip to content

fix: advence filter lable color#560

Open
Mateeb-Haider wants to merge 2 commits intofossasia:mainfrom
Mateeb-Haider:fix/advance-filter-color-for-dark-mode
Open

fix: advence filter lable color#560
Mateeb-Haider wants to merge 2 commits intofossasia:mainfrom
Mateeb-Haider:fix/advance-filter-color-for-dark-mode

Conversation

@Mateeb-Haider
Copy link
Copy Markdown
Contributor

@Mateeb-Haider Mateeb-Haider commented Apr 16, 2026

📌 Fixes

Fixes #559


📝 Summary of Changes

just add the tailwind class for dark mode

📸 Screenshots / Demo (if UI-related)

Before
image
After
image


✅ Checklist

[x] I’ve tested my changes locally
[x] My code follows the project’s code style guidelines


👀 Reviewer Notes

Summary by Sourcery

Bug Fixes:

  • Fix advanced filters label using a fixed gray color that did not adapt correctly in dark mode.

Copilot AI review requested due to automatic review settings April 16, 2026 04:56
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 16, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the advanced filters summary label styling to inherit text color, ensuring it adapts correctly in dark mode.

File-Level Changes

Change Details Files
Update advanced filters summary label text color to inherit from parent, fixing dark mode contrast issues.
  • Change the summary element text color class from a fixed gray tone to inherit the color from its parent, allowing theme-based styling (including dark mode) to apply correctly.
src/popup.html

Assessment against linked issues

Issue Objective Addressed Explanation
#559 Update the Advanced Filters label styling so its text color is compatible with dark mode.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the summary text now inherits color for dark mode, consider updating the chevron icon (text-gray-500) to also use an inherited or theme-aware color so the disclosure control looks consistent across themes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the summary text now inherits color for dark mode, consider updating the chevron icon (`text-gray-500`) to also use an inherited or theme-aware color so the disclosure control looks consistent across themes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the “Advanced Filters” label text color when dark mode is enabled in the popup UI (Issue #559) by removing the hardcoded light-mode text color on the <summary> element so it can follow the dark-mode styling.

Changes:

  • Updated the Advanced Filters <summary> text color class from text-gray-800 to text-inherit in src/popup.html.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/popup.html Outdated

<details class="group mb-4" style="margin-top: 1rem;">
<summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm text-gray-800 outline-none select-none pr-1">
<summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm text-inherit outline-none select-none pr-1">
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text-inherit is not present in the shipped src/tailwindcss.css, so this utility class has no effect and is effectively dead code. Since the actual fix here is removing the hardcoded text-gray-800 (so the <summary> can inherit the .dark-mode text color), consider dropping text-inherit entirely, or regenerate/update tailwindcss.css so text-inherit (and any other new utilities) are included.

Suggested change
<summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm text-inherit outline-none select-none pr-1">
<summary class="flex items-center justify-between cursor-pointer list-none font-medium text-sm outline-none select-none pr-1">

Copilot uses AI. Check for mistakes.
@Mateeb-Haider
Copy link
Copy Markdown
Contributor Author

@mariobehling @vedansh-5 While this is not a critical issue, it does impact the user experience. If the advanced filter text becomes invisible in dark mode, users will struggle to use the feature. Please review and merge the fix at your earliest convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: The advance filter label color is not compatible with dark mode.

2 participants