Skip to content

Fix flaky Cypress image tests using tolerance-based assertions #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nikita2106-05 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky Cypress image tests using tolerance-based assertions #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 41 additions & 14 deletions cypress/integration/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const [moveX, moveY] = [12, 34]; // required for drag/drop action
const [imgWidth, imgHeight] = [255, 510]; // required for drag/drop action
const basepos = 10; // required for drag/drop action

function expectCloseTo(val, expected, tolerance = 1) {
expect(parseFloat(val)).to.be.closeTo(expected, tolerance);
}
describe('Image Pane', () => {
it('image_basic', () => {
cy.run('image_basic')
Expand All @@ -36,11 +39,19 @@ describe('Image Pane', () => {

// check new position
cy.get(container_selector)
.should('have.css', 'top', `${moveY}px`)
.should('have.css', 'left', `${moveX}px`);
.invoke('css', 'top')
.then((val) => expectCloseTo(val, moveY));

cy.get(container_selector)
.invoke('css', 'left')
.then((val) => expectCloseTo(val, moveX));
cy.get(img_selector)
.should('have.attr', 'width', `${imgWidth}px`)
.should('have.attr', 'height', `${imgHeight}px`);
.invoke('attr', 'width')
.then((val) => expectCloseTo(val, imgWidth));

cy.get(img_selector)
.invoke('attr', 'height')
.then((val) => expectCloseTo(val, imgHeight));

// drag again
cy.get(img_selector)
Expand All @@ -66,8 +77,12 @@ describe('Image Pane', () => {

// check new position & image size
cy.get(container_selector)
.should('have.css', 'top', '0px')
.should('have.css', 'left', '0px');
.invoke('css', 'top')
.then((val) => expectCloseTo(val, 0));

cy.get(container_selector)
.invoke('css', 'left')
.then((val) => expectCloseTo(val, 0));
cy.get(img_selector)
.should('have.attr', 'width', `${imgWidth}px`)
.should('have.attr', 'height', `${imgHeight}px`);
Expand Down Expand Up @@ -112,14 +127,22 @@ describe('Image Pane', () => {
clientX: 0,
clientY: 0,
})
.should('have.attr', 'width', '156px')
.should('have.attr', 'height', '312px');
.invoke('attr', 'width')
.then((val) => expectCloseTo(val, 156));

cy.get(img_selector)
.invoke('attr', 'height')
.then((val) => expectCloseTo(val, 312));

// check new position
cy.get(container_selector)
.first()
.should('have.css', 'top', '-32.658px')
.should('have.css', 'left', '-3.93469px');
.invoke('css', 'top')
.then((val) => expectCloseTo(val, -32.658));

cy.get(container_selector)
.invoke('css', 'left')
.then((val) => expectCloseTo(val, -3.93469));
});

it('Image Zoom From Image Center (Ctrl + Wheel)', () => {
Expand All @@ -141,7 +164,6 @@ describe('Image Pane', () => {
cy.get(container_selector)
.first()
.should('have.css', 'top', '105.77px')
.should('have.css', 'left', '49.9706px');
});

it('Image Move & Zoom', () => {
Expand Down Expand Up @@ -184,7 +206,8 @@ describe('Image Pane', () => {
// check new position
cy.get(container_selector)
.first()
.should('have.css', 'top', `139.77px`)
.invoke('css', 'top')
.then((val) => expectCloseTo(val, 139.77));
.should('have.css', 'left', '61.9706px');
cy.get(img_selector)
.should('have.attr', 'width', '156px')
Expand Down Expand Up @@ -251,8 +274,12 @@ describe('Image Pane', () => {
cy.run('image_grid', { asyncrun: true });
cy.get(img_selector)
.should('have.length', 1)
.should('have.attr', 'width', '543px')
.should('have.attr', 'height', '204px');
.invoke('attr', 'width')
.then((val) => expectCloseTo(val, 543));

cy.get(img_selector)
.invoke('attr', 'height')
.then((val) => expectCloseTo(val, 204));
});

it('image_svg', () => {
Expand Down