Skip to content

fix: improve authentication error handling in check_auth #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vidhushaaa30 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: improve authentication error handling in check_auth #1069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc865f
maintain streak
Vidhushaaa30 Mar 12, 2026
5586ecb
Improve authentication error handling with proper status and response
Vidhushaaa30 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions py/visdom/utils/server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ def _check_auth(handler, *args, **kwargs):
# TODO this should call a shared method of the handler
handler.last_access = time.time()
if handler.login_enabled and not handler.current_user:
handler.set_status(400)
return
handler.set_status(401)
handler.write({"error": "Authentication required"})
Comment on lines +56 to +57
Copy link
Contributor

@sourcery-ai sourcery-ai bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The indentation on these new lines is inconsistent with the surrounding block and may cause an IndentationError.

The new lines under if handler.login_enabled and not handler.current_user: have one fewer leading space than the original ones. In Python, that mismatch within the same block can raise an IndentationError. Please align the indentation of the new set_status, write, and return lines exactly with the original ones.

return
f(handler, *args, **kwargs)

return _check_auth
Expand Down