Updating CONTRIBUTING.md #Issue - 1070#1073
Open
Garima-149 wants to merge 2 commits intofossasia:masterfrom
Open
Updating CONTRIBUTING.md #Issue - 1070#1073Garima-149 wants to merge 2 commits intofossasia:masterfrom
Garima-149 wants to merge 2 commits intofossasia:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CONTRIBUTING.md with troubleshooting guidance for a common Windows setup error involving the missing pkg_resources module, while making minor formatting edits in the existing visdom troubleshooting section. Flow diagram for resolving pkg_resources ModuleNotFoundError during setupflowchart TD
A[Contributor runs project setup or start command] --> B{Does ModuleNotFoundError for pkg_resources occur?}
B -- No --> C[Continue normal setup and contribution workflow]
B -- Yes --> D[Open CONTRIBUTING documentation troubleshooting section]
D --> E[Identify guidance for pkg_resources error]
E --> F[Run command: pip install --upgrade setuptools]
F --> G[Restart environment such as terminal or IDE]
G --> H{Do project commands still fail?}
H -- No --> I[Setup succeeds and contributor proceeds]
H -- Yes --> J[Reinstall project dependencies from requirements file]
J --> K{Do project commands succeed now?}
K -- Yes --> I[Setup succeeds and contributor proceeds]
K -- No --> L[Seek further help by opening an issue or asking maintainers]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The updated visdom command now has extra spaces inside the backticks (
python -m visdom.server); please remove the leading/trailing spaces so the inline command renders correctly. - There appears to be an unintended stray
viline added before the visdom server restart bullet; please remove it to avoid confusion. - In the new
pkg_resourcestroubleshooting section, consider formatting the error message and commands as fenced code blocks and fixing minor wording/capitalization (e.g.,Windows OS) to improve clarity and consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated visdom command now has extra spaces inside the backticks (` python -m visdom.server `); please remove the leading/trailing spaces so the inline command renders correctly.
- There appears to be an unintended stray `vi` line added before the visdom server restart bullet; please remove it to avoid confusion.
- In the new `pkg_resources` troubleshooting section, consider formatting the error message and commands as fenced code blocks and fixing minor wording/capitalization (e.g., `Windows OS`) to improve clarity and consistency.
## Individual Comments
### Comment 1
<location path="CONTRIBUTING.md" line_range="74" />
<code_context>
For some pip installs, this approach does not always properly link the visdom
module. In that case, try running `python setup.py install` instead.
+**Issue: Error related to `pkg_resources` during setup in Windows Os:**
+While setting up the project, you may encounter the following error:
+ModuleNotFoundError: No module named 'pkg_resources'
</code_context>
<issue_to_address>
**issue (typo):** Capitalize "OS" in "Windows OS".
In the heading, change "Windows Os" to "Windows OS".
```suggestion
**Issue: Error related to `pkg_resources` during setup in Windows OS:**
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<1070>
Summary
This PR improves the setup documentation by addressing a common issue related to the
pkg_resourcesmodule that new contributors may encounter.Problem
While setting up the project, a
ModuleNotFoundError: No module named 'pkg_resources'error can occur if the required dependency is missing or not properly configured. This can create confusion for first-time contributors.Changes
pkg_resourcesis part of thesetuptoolspackageImpact
This improves the onboarding experience for new contributors by:
Testing
setuptoolsin a clean environmentSummary by Sourcery
Documentation: