fix: remove invalid user/style.css reference from index.html

[KushDutta23]

Fix: Remove invalid static CSS path

Problem

The frontend attempted to load a stylesheet from ../user/style.css, which does not exist, causing a static file error.

Solution

• Removed incorrect stylesheet reference
• Kept the valid css/style.css import

Result

• No more static file errors
• UI loads correctly

Summary by Sourcery

Bug Fixes:

• Eliminate reference to a non-existent user stylesheet in index.html that caused static file load errors.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts stylesheet links in the Visdom frontend index.html, replacing the invalid ../user/style.css static path with another reference to css/style.css so all referenced stylesheets resolve via the static_url helper.

Sequence diagram for loading stylesheets via static_url after fix

sequenceDiagram
    actor User
    participant Browser
    participant Server

    User->>Browser: Open Visdom index.html
    Browser->>Server: GET /static/index.html
    Server-->>Browser: 200 index.html (with css/style.css links)

    Browser->>Server: GET static_url(css/style.css)
    Server-->>Browser: 200 css/style.css

    Browser->>Server: GET static_url(css/network.css)
    Server-->>Browser: 200 network.css

    Note right of Browser: Apply styles from css/style.css and css/network.css
    Note right of User: Sees correctly styled UI without static file errors

Loading

File-Level Changes

Change	Details	Files
Replaced the invalid ../user/style.css stylesheet reference with a second css/style.css reference in the Visdom static index page.	Updated the final stylesheet tag to use static_url("css/style.css") instead of static_url("../user/style.css"). Left the existing css/style.css and css/network.css stylesheet imports unchanged.	py/visdom/static/index.html

Possibly linked issues

• #pending error: Yes. The PR removes the invalid ../user/style.css reference that causes the static file error described in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• The new line still references css/style.css, resulting in a duplicate stylesheet import instead of actually removing the invalid ../user/style.css reference—consider either deleting the line entirely or pointing it to the intended different stylesheet if one exists.
• The indentation of the newly added <link> tag is off by one space compared to the surrounding lines; aligning it will keep the HTML formatting consistent.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new line still references `css/style.css`, resulting in a duplicate stylesheet import instead of actually removing the invalid `../user/style.css` reference—consider either deleting the line entirely or pointing it to the intended different stylesheet if one exists.
- The indentation of the newly added `<link>` tag is off by one space compared to the surrounding lines; aligning it will keep the HTML formatting consistent.

## Individual Comments

### Comment 1
<location path="py/visdom/static/index.html" line_range="64" />
<code_context>
     </script>
     <script src={{ static_url("js/main.js") }}></script>
     <link rel="stylesheet" href={{ static_url("css/style.css") }}>
-    <link rel="stylesheet" href={{ static_url("../user/style.css") }}>
+   <link rel="stylesheet" href={{ static_url("css/style.css") }}>
</code_context>
<issue_to_address>
**issue (bug_risk):** Duplicated reference to css/style.css likely replaces the intended ../user/style.css include.

This now loads `css/style.css` twice and drops the previous `../user/style.css`, which appears to have been intended for user-specific overrides. If those overrides are still needed, please restore the original path or otherwise clarify which distinct stylesheet should be referenced here.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Duplicated reference to css/style.css likely replaces the intended ../user/style.css include.

This now loads css/style.css twice and drops the previous ../user/style.css, which appears to have been intended for user-specific overrides. If those overrides are still needed, please restore the original path or otherwise clarify which distinct stylesheet should be referenced here.

[KushDutta23]

Thanks for the feedback!

You're right — the previous change introduced a duplicate reference to css/style.css, which was not the intended fix.

The original ../user/style.css path appears to have been meant for user-specific overrides, but since the path is invalid and no corresponding stylesheet exists in the repository, I have removed the reference entirely instead of duplicating the base stylesheet.

Please let me know if a dedicated user override stylesheet should be added instead.

[sourcery-ai]

Good catch on the missing file – your reasoning makes sense.

Looking at the code and docs, Visdom already supports user‑specific CSS via the config/env paths rather than a ../user/style.css file under static:

• py/visdom/server/app.py and web_handlers.py explicitly handle a style.css served from the user config directory or env_path.
• The README documents this behavior:

  By placing a style.css in your user config directory, visdom will serve the customized css file along with the default style-file. In addition, it is also possible to create a project-specific file; just place the file style.css in your env_path.

So the ../user/style.css reference in index.html was actually redundant and pointed at the wrong place. The correct flow is:

1. Always include the base stylesheet:

   <link rel="stylesheet" href={{ static_url("css/style.css") }}>

2. Let the backend optionally inject an additional style.css from the user config/env path when present (which the server already supports), instead of hardcoding a second <link> in the HTML.

Given that, your current change (removing the invalid ../user/style.css reference and avoiding a duplicate css/style.css link) is the right fix. No extra user override stylesheet needs to be added under static/.

You might consider adding a short note in the PR description (or commit message) referencing the documented user-CSS mechanism in the README, but code-wise I’m happy with this direction.