Chore: add test, demo, update readme and export(html) for table api - #1686
Open
rajnisht7 wants to merge 10 commits into
Open
Chore: add test, demo, update readme and export(html) for table api#1686rajnisht7 wants to merge 10 commits into
rajnisht7 wants to merge 10 commits into
Conversation
Contributor
Reviewer's GuideAdds documentation, demo usage, tests, and HTML export support for the new vis.table API, and wires it into existing demo and pane regression tests with expected table dimensions. Sequence diagram for vis.table HTML export renderingsequenceDiagram
actor User
participant VisdomClient
participant ExportTemplate
participant DOM
User->>VisdomClient: exportHtml
VisdomClient->>ExportTemplate: renderContent(id, pane, pc)
ExportTemplate->>ExportTemplate: check pane.content.__type
alt t == table
ExportTemplate->>ExportTemplate: read c.headers and c.rows
ExportTemplate->>DOM: mkEl(table)
ExportTemplate->>DOM: createTHead().insertRow()
ExportTemplate->>DOM: createTBody()
ExportTemplate->>DOM: insertRow() for each row
ExportTemplate->>DOM: appendChild(tbl)
else t != table
ExportTemplate->>ExportTemplate: handle other pane types
end
File-Level Changes
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the exportTemplate.js table renderer, you bail out when headers is empty even if rows has data; consider either deriving headers from the first row or rendering a headerless table so export works for data-only tables.
- The table export currently assumes each row is an array and indexes by header position; if vis.table supports dict-style rows (as described in the README), you may want to normalize dict rows to arrays in the export path to avoid silently skipping or misordering values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the exportTemplate.js table renderer, you bail out when headers is empty even if rows has data; consider either deriving headers from the first row or rendering a headerless table so export works for data-only tables.
- The table export currently assumes each row is an array and indexes by header position; if vis.table supports dict-style rows (as described in the README), you may want to normalize dict rows to arrays in the export path to avoid silently skipping or misordering values.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
rajnisht7
requested review from
Jayantparashar10,
Manik-Khajuria-5,
tonypzy and
vedansh-5
August 7, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds demo, test for the table api and updates the readme also enables the export of table in html format
This PR is made on top of #1677
Motivation and Context
Adding test, demo and updating readme for table API and adding in exportHtml
How Has This Been Tested?
verified the tests by executing locally all test passed
Screenshots :
the pdf: visdom_table_test_2026-08-04_07-20.html
before:

pdf: visdom_table_test_2026-08-03_18-56.html
Types of changes
Checklist:
py/visdom/VERSIONaccording to Semantic VersioningSummary by Sourcery
Document and demonstrate the new editable table visualization API and support exporting table panes to HTML in automated tests and demos.
New Features:
Enhancements:
Tests: