Complete Playwright migration and remove Cypress - #1691
Draft
tonypzy wants to merge 13 commits into
Draft
Conversation
…e-select-tree to avoid hidden aria-live nodes
1. openEnv (helpers.js): Use getByText with exact: true instead of locator('text=...') to prevent substring matches on hidden child nodes inside collapsed groups.
2. ctrlWheel (image.spec.js): Default clientX and clientY to target element center when undefined, matching Cypress trigger('wheel') behavior.
3. image_callback2 (image.spec.js): Click pane to set focusedPaneID before sending arrow keypresses via page.keyboard so Visdom publishes KeyPress events.
4. compare mode download (image.spec.js): Collect download events via page.on('download') and poll until 2 files are received.
…le state after in openEnv helper
Contributor
Reviewer's GuideMigrates all E2E and visual regression testing from Cypress to Playwright, updates CI workflows and documentation to reflect the new Playwright-based workflows, removes Cypress-specific configuration and dependencies, and adds new Playwright specs and helpers to maintain test coverage and image/pane behavior parity. Flow diagram for Playwright environment dropdown helpersflowchart TD
S[Start_openEnv] --> C1[Check_if_dropdown_visible]
C1 -->|No| O1[Click_env_selector_with_force]
O1 --> W1[Wait_for_dropdown_visible]
C1 -->|Yes| F1[Find_env_tree]
W1 --> F1
F1 --> T1[Compute_expectedText_from_env_name]
T1 --> V1[Wait_for_group_label_visible_using_getByText_exact]
V1 --> X1[expandAllEnvGroups]
X1 --> V2[Wait_for_env_name_visible_using_getByText_exact]
V2 --> CL[Click_env_name_with_force]
CL --> CD[closeEnvDropdown]
CD --> E[End]
subgraph closeEnvDropdown
C2[Locate_visible_dropdown]
C2 -->|Visible| C3[Click_env_selector_with_force]
C3 --> C4[Wait_for_dropdown_hidden]
C4 --> C5[If_still_visible_press_Escape_and_wait_hidden]
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
py/visdom/VERSIONaccording to Semantic VersioningSummary by Sourcery
Migrate end-to-end and visual regression testing from Cypress to Playwright across codebase and CI, removing Cypress tooling and adding Playwright coverage for key panes.
New Features:
Bug Fixes:
Enhancements:
CI:
Documentation:
Tests:
Chores: