Fix: Remove separate persistence flow from update_comment in socket handler - #1693
Open
rajnisht7 wants to merge 1 commit into
Open
Fix: Remove separate persistence flow from update_comment in socket handler#1693rajnisht7 wants to merge 1 commit into
rajnisht7 wants to merge 1 commit into
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the explicit background persistence call from the socket handler’s update_comment path so that comment updates rely on the standard, shared persistence mechanism used by other commands. Sequence diagram for updated update_comment socket flowsequenceDiagram
actor Client
participant SocketHandler
participant Broadcast
Client->>SocketHandler: on_message(update_comment)
SocketHandler->>Broadcast: broadcast_packet
Broadcast-->>Client: updated_comment_broadcast
Broadcast-->>Client: updated_comment_broadcast (other listeners)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
rajnisht7
requested review from
Jayantparashar10,
Manik-Khajuria-5,
tonypzy and
vedansh-5
August 7, 2026 09:49
Jayantparashar10
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the separate flow from update_comment
Motivation and Context
remove separate flow from update_comment making consistency with other end points
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
py/visdom/VERSIONaccording to Semantic VersioningSummary by Sourcery
Enhancements: