Create signatures only if missing (new create_signatures option) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed config.inc.php.dist and identify_from_director.php
Contributor
|
Hi! Many thanks for your PR, It looks quite good, so it will be probably get merged after testing / I will have a deeper look at it on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config option identity_from_directory_create_signatures.
When create_signatures=true and update_signatures=false, the plugin creates signatures only if the identity has no signature yet and does not overwrite user-edited signatures on later logins.
Default behavior remains unchanged unless the new option is enabled.