Replaced table markup with wrapper #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced table markup with wrapper and updated the indentation so they are consistent
rafibomb
reviewed
Apr 27, 2017
| </head> | ||
| <body> | ||
| <span class="preheader">{{description}}</span> | ||
| <wrapper class="body"> |
Member
There was a problem hiding this comment.
I'm concerned that the <center> tag is missing here along with some of the classes for centering. Do you have any tests that show the container is centering works on all email clients supported?
DanielRuf
suggested changes
Nov 24, 2019
Contributor
DanielRuf
left a comment
DanielRuf
left a comment
There was a problem hiding this comment.
See the last feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced table markup with wrapper and updated the indentation so they
are consistent