Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
Vendor Dependency Updates
Sassy-Lists Compatibility: Patching the included sassy-lists vendor files to support Dart Sass 2. This includes adding
@usesass:listand updating internal function calls to be module-aware.Sass Module System Migration
Replaced
@importwith@use: Updated core components and settings files to use the Sass module system. This ensures better encapsulation and avoids global namespace pollution.Explicit Namespacing: Updated references to variables and mixins to use their respective namespaces (e.g., migrating from global access to
util.rem-calc()orgrid.$grid-column-count).Circular Dependency Resolution
Math & Unit Modules: Resolved a circular dependency between the math and unit utility modules.
Improved Math Calculations: Replaced deprecated division syntax with modern math functions (e.g., math.div logic) to ensure compatibility with Dart Sass 2's strict math rules.
Namespace & Scoping Fixes
Grid Module Scoping: Standardized the use of
$grid-column-countwithin the grid modules. Fixed instances whererow.$grid-column-countwas incorrectly referenced instead of the local grid namespace.Private Variable Visibility: Refactored variables previously starting with a hyphen (e.g.,
$-zf-bp-value). In Dart Sass 2 modules, variables starting with-or_are private and cannot be accessed across files or globally. These were updated to public variables where cross-module access was required.Syntax Modernization
Wrapped specific styles in nested blocks where necessary to comply with new Sass nesting and scoping rules (e.g., flex-grid-column logic).
Testing Performed
I temporarily added
@include foundation-everything;to the main file and ran the build with every possible combination of parameters for the foundation-everything mixin. The project now builds with zero errors and zero deprecation warnings under Dart Sass 2.0.