config: Define proxy providing function in config#112
Merged
Conversation
Member
|
The idea works for me. Just remember to pull out the fmt.Printf debugging before you finalize. |
mike-sul
force-pushed
the
improve-proxy-config
branch
from
aa3d786 to
f9eb6ed
Compare
Collaborator
Author
|
@doanac I verified it for the aklite v96 and the latest version of the satellite server just to make sure no regression, and it works fine. |
doanac
reviewed
Dec 17, 2025
Defining a compose app proxy as a function in the configuration provides the compose app API clients to define runtime logic for obtaining URL and/or CA cert of the proxy server. In particular, a client does not need to know which of the API functions makes a call to a container registry, hence it does not need to set the proxy before invoking each such the API call. Instead composeapp invokes a client provided function/callback to provide the proxy URL and CA whenever a random API function of composeapp needs it. Signed-off-by: Mike Sul <mike.sul@foundries.io>
mike-sul
force-pushed
the
improve-proxy-config
branch
from
f9eb6ed to
48ee670
Compare
doanac
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining a compose app proxy as a function in the configuration provides the compose app API clients to define runtime logic for obtaining URL and/or CA cert of the proxy server.
In particular, a client does not need to know which of the API functions makes a call to a container registry, hence it does not need to set the proxy before invoking each such the API call. Instead composeapp invokes a client provided function/callback to provide the proxy URL and CA whenever a random API function of composeapp needs it.