base: compose-apps-early-start: avoid composectl call with empty apps list#1720
Open
MrCry0 wants to merge 1 commit into
Open
base: compose-apps-early-start: avoid composectl call with empty apps list#1720MrCry0 wants to merge 1 commit into
MrCry0 wants to merge 1 commit into
Conversation
MrCry0
requested review from
angolini,
quaresmajose and
ricardosalveti
as code owners
angolini
approved these changes
Mar 17, 2026
angolini
left a comment
angolini
left a comment
Contributor
There was a problem hiding this comment.
Can you describe how you have tested it?
Contributor
|
@caiotpereira take a look in this PR and let's talk about dependency and testing |
Contributor
Member
Contributor
|
@quaresmajose comented that there is one commit here that is not present in the other PRs. Let's keep this PR open until @MrCry0 can review and rebase the changes |
… list In start_restorable_apps(), when shortlist is empty (all default apps are already present locally) and the compose-apps directory is also empty, the code fell into an else branch and executed: composectl run --apps "" Since shortlist is empty, there are no apps to restore. Calling composectl with an empty --apps argument is pointless and may trigger an error that fails the service. Replace this branch with a log message to make the no-op explicit. Fixes: 0eecf72 ("base: compose-apps-early-start: update compose apps early start") Signed-off-by: Oleksandr Suvorov <cryosay@gmail.com>
MrCry0
force-pushed
the
cryo/fix-compose-apps-early
branch
from
276664a to
8b2135a
Compare
MrCry0
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In start_restorable_apps(), when shortlist is empty (all default apps are already present locally) and the compose-apps directory is also empty, the code fell into an else branch and executed:
Since shortlist is empty, there are no apps to restore. Calling composectl with an empty --apps argument is pointless and may trigger an error that fails the service.
Replace this branch with a log message to make the no-op explicit.