Bump solar version #264
Merged
Bump solar version #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grandizzy
commented
May 10, 2025
•
grandizzy
commented
- prereq for forge lint PR feat(forge): forge lint foundry#10405
- solar 0.1.3 requires rust 1.86 so this breaks compatibility with older rust versions - bump msrv
DaniPopes
reviewed
May 10, 2025
| exclude: | ||
| # Skip because some features have higher MSRV. | ||
| - rust: "1.83" # MSRV | ||
| flags: "--all-features" |
There was a problem hiding this comment.
this is not right, you bump the msrv not remove the test that checks compatibility :D
There was a problem hiding this comment.
redone, pls check
DaniPopes
approved these changes
May 10, 2025
|
this breaks the msrv policy but whatever, it should just be latest msrv |
This was referenced May 12, 2025
Open
mattsse
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.