Skip to content

chore: replaced anvil hardforks with alloy hardforks #10612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

chore: replaced anvil hardforks with alloy hardforks #10612

wants to merge 11 commits into from

Conversation

Rimeeeeee
Copy link
Contributor

@Rimeeeeee Rimeeeeee commented May 23, 2025 •
edited
Loading

fixes #10609
removed redundant EthereumHardfork and OptimismHardfork
added standalone fxns spec_id_from_optimism_hardfork, spec_id_from_ethereum_hardfork and ethereum_hardfork_from_block_tag for support
added tests to test standalone fxns

mattsse
mattsse requested changes May 23, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start
looks like we also need the inverse of chain +u64 -> Option<Hardfork>?

let's do a rewrite of

impl<T: Into<BlockNumberOrTag>> From<T> for EthereumHardfork {

as regular fn here first and then we move this to the hardforks crate

@Rimeeeeee Rimeeeeee mentioned this pull request May 24, 2025
Merged
@Rimeeeeee Rimeeeeee requested a review from mattsse May 24, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: replace anvil hardforks with alloy-hardforks
2 participants
@Rimeeeeee @mattsse