-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: replaced anvil hardforks with alloy hardforks #10612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replaced anvil hardforks with alloy hardforks #10612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great start
looks like we also need the inverse of chain +u64 -> Option<Hardfork>
?
let's do a rewrite of
impl<T: Into<BlockNumberOrTag>> From<T> for EthereumHardfork {
as regular fn here first and then we move this to the hardforks crate
Lgtm! Pending final upstream changes in Thanks @Rimeeeeee! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #10609
removed redundant
EthereumHardfork
andOptimismHardfork
added standalone fxns
spec_id_from_optimism_hardfork
,spec_id_from_ethereum_hardfork
andethereum_hardfork_from_block_tag
for supportadded tests to test standalone fxns