feat(forge build): cache project selectors by default #10651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mablr
commented
May 28, 2025
mablr
force-pushed
the
feature/forge-build-cache-selectors
branch
from
b28c4e5 to
cda756f
Compare
Calls `cache_local_signatures` function like the "forge selectors cache" command.
mablr
force-pushed
the
feature/forge-build-cache-selectors
branch
from
cda756f to
a70c367
Compare
mablr
changed the title
--selectors_cache option
zerosnacks
previously approved these changes
May 28, 2025
zerosnacks
reviewed
May 28, 2025
…ptional `cache_dir` No more need to unwrap the option value returned foundry's `config` crate
mablr
force-pushed
the
feature/forge-build-cache-selectors
branch
from
b519bf6 to
fd92f8c
Compare
mablr
commented
May 28, 2025
crates/cli/src/utils/cmd.rs
Outdated
| let Some(cache_dir) = cache_dir else { | ||
| eyre::bail!("Failed to get `cache_dir` to generate local signatures."); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I updated cache_local_signatures in a separate commit, squash it if you think it's not necessary.
grandizzy
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #10640
Solution
Calls
cache_local_signaturesfunction like the "forge selectors cache" command.Remark
cache_local_signaturesfunction has been updated to accept an optionalcache_dir, no more need tounwrap()the option value returned foundry'sconfigcrate.PR Checklist
Added Documentation