refactor(evm): remove unused snap_tx_env from BackendStateSnapshot#13752
Merged
zerosnacks merged 3 commits intofoundry-rs:masterfrom Mar 13, 2026
Merged
refactor(evm): remove unused snap_tx_env from BackendStateSnapshot#13752zerosnacks merged 3 commits intofoundry-rs:masterfrom
snap_tx_env from BackendStateSnapshot#13752zerosnacks merged 3 commits intofoundry-rs:masterfrom
Conversation
The `snap_tx_env` field was stored on every state snapshot but never read back on revert — it was destructured as `_`. Remove it along with the `tx_env` parameter from `DatabaseExt::snapshot_state`, avoiding an unnecessary `TxEnv` clone on every snapshot.
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
figtracer
changed the title
snap_tx_env from BackendStateSnapshot
figtracer
force-pushed
the
refactor/remove-snap-tx-env
branch
from
9a6e688 to
d13a88f
Compare
…lization Amp-Thread-ID: https://ampcode.com/threads/T-019ce8e6-b2c7-71dd-8f3e-df34110d8a20 Co-authored-by: Amp <amp@ampcode.com>
figtracer
force-pushed
the
refactor/remove-snap-tx-env
branch
from
563e592 to
ddca975
Compare
zerosnacks
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snap_tx_envfield fromBackendStateSnapshot— it was stored on every snapshot but destructured as_on revert, never actually read backtx_envparameter fromDatabaseExt::snapshot_state, avoiding an unnecessaryTxEnvclone on every snapshotEvmEnvconstruction in the cheatcode caller to avoid cloningTxEnvviaclone_evm_and_tx