fix(chisel): use config root and script dir in !export#13756
Open
FredPhilipy wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(chisel): use config root and script dir in !export#13756FredPhilipy wants to merge 1 commit intofoundry-rs:masterfrom
FredPhilipy wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!exportchecks forfoundry.tomlin the current working directory and always writes to the relative pathscript/REPL.s.sol. This breaks when chisel is launched from a subdirectory or when the user has configured a customscriptdirectory infoundry.toml— the check fails or the file ends up in the wrong place.The dispatcher already holds the loaded
Configwith the correctrootandscriptpaths. This PR replaces the hardcoded paths with the config values and updates the output message to show the actual export path.