refactor(evm): add IntoInstructionResult bound to FoundryEvmFactory#14099
Merged
zerosnacks merged 1 commit intofoundry-rs:masterfrom Apr 3, 2026
Merged
Conversation
…ryEvmFactory` Move `IntoInstructionResult` from anvil to foundry-evm-core with impls for `HaltReason`, `OpHaltReason`, and `TempoHaltReason`. Add `HaltReason: IntoInstructionResult` bound to `FoundryEvmFactory` so generic code can convert halt reasons to instruction results.
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
figtracer
changed the title
IntoInstructionResult to core and bound FoundryEvmFactoryIntoInstructionResult bound to FoundryEvmFactory
stevencartavia
approved these changes
Apr 3, 2026
zerosnacks
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Moves
IntoInstructionResultfrom anvil tofoundry-evm-coreand addsHaltReason: IntoInstructionResultas a bound onFoundryEvmFactory. This enables generic code to convert network-specific halt reasons intoInstructionResultwithout being pinned to Ethereum types.