fix: < to <= in validate_uint_mutation#14459
Merged
mablr merged 1 commit intofoundry-rs:masterfrom Apr 28, 2026
Merged
Conversation
cuiweixie
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
grandizzy
reviewed
Apr 27, 2026
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
makes sense, ty! mind to add an unit test to prevent regressions?
cuiweixie
force-pushed
the
fix/less-than
branch
from
d761a5e to
1304e4a
Compare
Contributor
Author
done |
cuiweixie
force-pushed
the
fix/less-than
branch
from
1304e4a to
bb172ad
Compare
Collaborator
stevencartavia
left a comment
stevencartavia
left a comment
There was a problem hiding this comment.
lgtm, please run cargo +nightly fmt
cuiweixie
force-pushed
the
fix/less-than
branch
from
bb172ad to
738b2f4
Compare
grandizzy
approved these changes
Apr 28, 2026
mablr
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.