fix(anvil): honor epoch slots for safe/finalized tags#14466
Open
solanaXpeter wants to merge 3 commits intofoundry-rs:masterfrom
Open
fix(anvil): honor epoch slots for safe/finalized tags#14466solanaXpeter wants to merge 3 commits intofoundry-rs:masterfrom
solanaXpeter wants to merge 3 commits intofoundry-rs:masterfrom
Conversation
solanaXpeter
requested review from
DaniPopes,
grandizzy,
mattsse and
zerosnacks
as code owners
solanaXpeter
requested review from
0xrusowsky,
figtracer,
mablr,
onbjerg and
stevencartavia
as code owners
mablr
approved these changes
Apr 28, 2026
Collaborator
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
Lgtm, thanks!
Pending another review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Anvil exposes
--slots-in-an-epoch, but some safe/finalized block tag paths still used a hard-coded 32-slot epoch. With a custom value,eth_feeHistoryand block lookup could resolve different heights for the same tag.Solution
Route
eth_feeHistorythrough the backend block-number conversion and pass the configured epoch length when resolving block hashes. Add a regression test that mines withslots_in_an_epoch = 2and checks safe/finalized tags for both block lookup and fee history.PR Checklist