Make cast logs decode logs data when signature is provided - #16322
Open
e1Ru1o wants to merge 3 commits into
Open
Make cast logs decode logs data when signature is provided#16322e1Ru1o wants to merge 3 commits into
cast logs decode logs data when signature is provided#16322e1Ru1o wants to merge 3 commits into
Conversation
e1Ru1o
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
August 22, 2026 01:05
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cast logsincluding indexed parameters, it should be able to decode the logs instead of just showing topics and data.cast decode-eventfails when the full event event signature is provided including the indexed parameters. It should be capable of dropping the indexed parameters and try to decode the event data, otherwise, users are forced to create the stripped signature manually.Solution
Just do the decodings/strippings as needed and try to show the data to the user
len(topics) - 1 = len(indexed-params)try to decode the logPR Checklist