fix(anvil): fix latest read isolation - #16368
Open
cruzdanilo wants to merge 1 commit into
Open
Conversation
cruzdanilo
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
August 25, 2026 20:02
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
figtracer
reviewed
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation
during successful mining, anvil could publish the new database state before the corresponding
evm_env. an overlappingeth_callatlatestcould therefore execute against state fromn+1with the block environment fromn.this follows #10709, which fixed an earlier race while resolving
latest, and #12417, which fixed another case where the rpc head and thenumberopcode disagreed. this change addresses the remaining publication race afterlatesthas already been resolved.solution
publish the updated execution environment while holding the existing database write lock after a successful state commit. live calls acquire the database read lock before cloning the environment, so they now observe either the old or new snapshot coherently while retaining concurrent call execution. the consistent
dbthenevm_envlock order has no reverse acquisition path and therefore introduces no deadlock cycle.a deterministic regression test fixes the mining and call ordering and verifies that state and block number come from the same snapshot.
codex assisted with codebase analysis, test generation, implementation, and drafting this pull request description.
pr checklist