refactor(primitives): centralize completeness checks - #16450
Merged
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
mattsse
as code owners
August 28, 2026 21:32
Contributor
✅ Changelog exemptA maintainer marked this pull request as not requiring a changelog entry. |
figtracer
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FoundryTransactionRequestrepeats transaction completeness checks acrossmissing_keys,complete_type, andoutput_tx_type_checked. This centralizes the shared type dispatch in a single helper while preserving the existing sidecarless EIP-4844 behavior inmissing_keys.Base benefits by adding EIP-8130 completeness validation in one place instead of repeating the same rule across all three methods.