test(forge): add optimism deployCode coverage - #16453
Merged
Merged
Conversation
Covers the OP EVM's nested-EVM frame execution path, which is only reachable through vm.deployCode, for the optimism network family.
mattsse
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
stevencartavia
as code owners
August 29, 2026 00:22
Contributor
✅ Changelog exemptA maintainer marked this pull request as not requiring a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16419.
NestedEvm::run_executionis reachable only throughvm.deployCode, and the optimism family was the sole network without coverage of that path — eth, monad, and tempo each exercise it, so a regression confined to the OP instantiation of the shared frame execution (including itsmap_op_errormapping andOpHandler's deposit-awarelast_frame_resultoverride) would ship with CI green.The test activates the optimism family via config, deploys a contract through
vm.deployCodewith a constructor argument, and asserts the deployed code is present and callable. It runs in default CI:optimismis a default feature offorge, and the network is selected purely throughfoundry.toml.Test-only change, needs
L-ignore.AI-assisted.