chore: clearer error message when function signature does not contain parentheses #9478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yipu3
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
yash-atreya
requested changes
Dec 4, 2024
Co-authored-by: Yash Atreya <[email protected]>
DaniPopes
previously approved these changes
Dec 4, 2024
|
Thanks! |
zerosnacks
changed the title
zerosnacks
reviewed
Dec 4, 2024
DaniPopes
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9479
When I wrongly input a function signature without parentheses:
./target/debug/cast call 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D 'deposit'The error message is a bit of confusing:
Which costs me some time to figure out what's the point.
A clearer error message is needed.
Solution
Change the message into: