-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(forge): init a git repo at root during init unless explicitely stated #9695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xvv
wants to merge
3
commits into
foundry-rs:master
Choose a base branch
from
0xvv:fix-git-submodules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xvv
I'm not sure how this fixes #3962 since the top-level
.gitmodules
file is still being modified even though you've created a subfolder in which the project resides, i.e., the foundry folder.The core issue here concerns how git submodules work and how
.gitmodules
must always be at the git root. Not sure if this is feasible since it would breakgit submodule
command that keeps the.gitmodules
file updated and always assumes it's at the root-level.See: https://git-scm.com/docs/gitsubmodules and https://git-scm.com/docs/gitmodules.
Maybe I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xvv did you get the chance to take a look at this? ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yash-atreya I think I don't understand your point.
I changed the default behavior to not modify the parent
.gitmodules
, which is the behavior in other comparable tools and fixes #3962. The.gitmodules
thus resides at the root of the newly created forge repo with the new dependencies as expected even if already contained in a git repository. The newly created forge repo can then become a module of the parent git repo.And I added the option to use an existing parent repo and
.gitmodules
if we are already in a git repository. Again the modules are declared at the root of the repository that contains the forge, it's just n levels above the forge folder. This is the existing behavior which I think we should move away from as a more modular approach seems better suited to me here but I left it as an option for flexibility and legacy behavior support.I don't think this would prevent anything regarding submodules management because either way you would be at the root of the git repository.
Let me know if I'm missing anything