Restore range_check as most costly factor in the corresponding gas test
#4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKowalski8
commented
Dec 23, 2025
| let _x: ContractAddress = 1234.try_into().unwrap(); | ||
| let _x: ContractAddress = 1234.try_into().unwrap(); | ||
| let _x: ContractAddress = 1234.try_into().unwrap(); | ||
| for _ in 0..1000_u16 { |
Member
Author
There was a problem hiding this comment.
Note: the smallest value that meets the conditions is around 250. I added more so that it wouldn't have to be updated with minor optimizations. I haven't noticed that it would have any real impact on execution time.
cptartur
reviewed
Dec 23, 2025
| // 96 = cost of deploy (see snforge_std_deploy_cost test) | ||
| // 6 = cost of 2344 cairo steps (because int(0.0025 * 2344) = 6) | ||
| // 0 l1_gas + 96 l1_data_gas + 6 * (100 / 0.0025) l2 gas | ||
| // 43 = cost of 1052 range check builtins (because int(0.04 * 1052) = 43) |
Member
There was a problem hiding this comment.
Why 1052 if there are 1000 iterations? The 52 rest are coming from other parts of the execution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4031
Introduced changes
range_checkas most costly factor again, notcairo_stepsChecklist
CHANGELOG.md