Display events in the debugging trace#4299
Merged
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Apr 22, 2026
integraledelebesgue
force-pushed
the
event-debugging/include-events
branch
from
8e2f690 to
c4c6426
Compare
integraledelebesgue
force-pushed
the
event-debugging/include-events
branch
2 times, most recently
from
ac520db to
5e31145
Compare
franciszekjob
left a comment
franciszekjob
left a comment
Contributor
There was a problem hiding this comment.
Let's mention the change in changelog
Otherwise LGTM
integraledelebesgue
force-pushed
the
event-debugging/include-events
branch
4 times, most recently
from
d6ed44a to
c5d1e90
Compare
franciszekjob
approved these changes
May 11, 2026
MKowalski8
approved these changes
May 13, 2026
MKowalski8
left a comment
MKowalski8
left a comment
Contributor
There was a problem hiding this comment.
Do you think adding test with some panic could be useful? I mean emmiting event before panic and checking if trace capture the event or not?
integraledelebesgue
force-pushed
the
event-debugging/include-events
branch
from
c5d1e90 to
f3d27f4
Compare
integraledelebesgue
force-pushed
the
event-debugging/include-events
branch
from
f3d27f4 to
daa4640
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist
CHANGELOG.md