Skip to content

fix: align confirmation prompt behavior with (Y/n) convention #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikhailUshakoff wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: align confirmation prompt behavior with (Y/n) convention #4350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

#### Fixed

- Fix `verify` command prompt behavior to correctly interpret empty input as "yes" for (Y/n) confirmation
- Bug in forge debugging and `--gas-report` that caused panic in case of a call to non-existent selector

## [0.60.0] - 2026-04-27
Expand Down Expand Up @@ -44,7 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
#### Changed

- In JSON output for `sncast utils` commands, the `"command"` field now includes the `utils` prefix (e.g. `"serialize"` -> `"utils serialize"`).
- Reworked profile layering in `snfoundry.toml`: `[sncast.default]` is always the base layer, and global-only profiles can work without a local config. Read more [here](https://foundry-rs.github.io/starknet-foundry/projects/configuration.html#interaction-between-local-and-global-profiles).
- Reworked profile layering in `snfoundry.toml`: `[sncast.default]` is always the base layer, and global-only profiles can work without a local config. Read more [here](https://foundry-rs.github.io/starknet-foundry/projects/configuration.html#interaction-between-local-and-global-profiles).
- Improved `snfoundry.toml` config error reporting.
- `--profile` now only determines `snfoundry.toml` profile. For Scarb profile, use `--scarb-profile` flag or `scarb-profile` from `snfoundry.toml` instead. Defaults to `release` if unspecified.

Expand Down
2 changes: 1 addition & 1 deletion crates/sncast/src/starknet_commands/verify/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ fn display_files_and_confirm(
);
let input: String = prompt(prompt_text)?;

if !input.to_lowercase().starts_with('y') {
if !input.is_empty() && !input.to_lowercase().starts_with('y') {
bail!("Verification aborted");
}
}
Expand Down