Skip to content

Don't return unnecessary diagnostics from macros#4361

Merged
piotmag769 merged 1 commit into
masterfrom
essa
May 15, 2026
Merged

Don't return unnecessary diagnostics from macros#4361
piotmag769 merged 1 commit into
masterfrom
essa

Conversation

@piotmag769

Copy link
Copy Markdown
Contributor

Introduced changes

  • check_error_free instead of is_empty - Derive fuzzable trait #4240 (comment)
  • stopped returning additional diags when parser error happen - this makes the UX better while writing the code. Now:
image

vs before:

image

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@piotmag769 piotmag769 requested a review from a team as a code owner May 15, 2026 00:41
@piotmag769 piotmag769 requested review from DelevoXDG and ddoktorski and removed request for a team May 15, 2026 00:41
@piotmag769 piotmag769 mentioned this pull request May 15, 2026
5 tasks
Comment thread crates/snforge-scarb-plugin/src/derives/fuzzable.rs
@piotmag769 piotmag769 requested a review from DelevoXDG May 15, 2026 10:36
Base automatically changed from claude to master May 15, 2026 10:53
@piotmag769 piotmag769 added this pull request to the merge queue May 15, 2026
Merged via the queue into master with commit 2a5e7a0 May 15, 2026
27 checks passed
@piotmag769 piotmag769 deleted the essa branch May 15, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants