POC: General combat data (unarmed strikes), forward activity targeting other items#6842
Draft
krbz999 wants to merge 2 commits intofoundryvtt:5.3.xfrom
Draft
POC: General combat data (unarmed strikes), forward activity targeting other items#6842krbz999 wants to merge 2 commits intofoundryvtt:5.3.xfrom
krbz999 wants to merge 2 commits intofoundryvtt:5.3.xfrom
Conversation
…rikes on CreatureData.
arbron
reviewed
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept pull request.
Adding an embedded model for Unarmed Strike data on Creatures means that any item can reference what the current unarmed strike will do with just
@combat.unarmed + @modas the formula. Effects would modify this, e.g., the Monk class would would apply effects targetingsystem.combat.unarmed.faces/.number.In addition, adds a
activity.itemstring field to the Forward activity to allow it to use a different item's activity. There are some more things here that aren't accounted for, like consumption and such, but as a proof of concept it works OK. (No UI changes in this PR.)