[#6675] add advantage mode for dodging and heavilyEncumbered conditions effects#6859
Open
Kapuzenjoe wants to merge 2 commits intofoundryvtt:5.3.xfrom
Open
[#6675] add advantage mode for dodging and heavilyEncumbered conditions effects#6859Kapuzenjoe wants to merge 2 commits intofoundryvtt:5.3.xfrom
Kapuzenjoe wants to merge 2 commits intofoundryvtt:5.3.xfrom
Conversation
Fyorl
added
system: active effects
priority: medium
strategic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A direct
movement.speed === 0check for the actor is not reliable inhasConditionEffect(), because movement has not been fully resolved yet during ability roll-mode preparation. Supporting that properly would require a broader change to preparation order or moving the rule to a later stage.Because of that, this PR uses the existing
noMovementcondition path instead. That keeps the logic consistent withCONFIG.DND5E.conditionEffectsand avoids a more invasive change for this issue.For the
heavilyEncumberedpart, I used the namestrengthDexterityConstitutionCheckDisadvantage. It is explicit, though I think something shorter likephysicalCheckDisadvantagecould also be a reasonable option.The attack disadvantage/advantage part is not addressed in this PR.