Skip to content

[#6839] Add placed encounter members to combat#6891

Open
Aioros wants to merge 1 commit intofoundryvtt:5.3.xfrom
Aioros:encounter-placement-combat
Open

[#6839] Add placed encounter members to combat#6891
Aioros wants to merge 1 commit intofoundryvtt:5.3.xfrom
Aioros:encounter-placement-combat

Conversation

@Aioros
Copy link
Copy Markdown
Contributor

@Aioros Aioros commented Apr 3, 2026

While creating combatants and rolling initiative for placed members is fairly straightforward, I think the main point of contention on the feature would be how to present the option and where it is actually stored. I opted for a client-setting-backed little dialog, shown right before the actual placement of the encounter members.

Closes #6839

Comment thread module/applications/actor/encounter-placement-dialog.mjs Outdated
@arbron arbron added ux User experience related features or bugs system: canvas Vision modes and scene interaction priority: medium labels Apr 6, 2026
Copy link
Copy Markdown
Collaborator

@arbron arbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably try to avoid the dialog solution if possible, instead having a setting in the Combat Settings config for what to do when placing actors from an encounter: "Add to Combat", "Add to Combat & Roll Initiative", "Do Nothing".

If there isn't already an existing combat, then nothing would happen.

Comment thread module/data/actor/encounter.mjs Outdated
Comment thread module/data/settings/encounter-placement-setting.mjs Outdated
@Aioros
Copy link
Copy Markdown
Contributor Author

Aioros commented Apr 6, 2026

The dialog was basically a personal preference coming from the way I imagined myself using the feature. I reasoned that if I had multiple encounters, and only wanted the combatants to be created for some of them, switching the setting back and forth would have felt more cumbersome, while this allows me to decide on the fly, and remember the last choice. I do trust your opinion more though, so let me prepare a different version.

If there isn't already an existing combat, then nothing would happen.

Not sure about this part, I thought creating the combat if it doesn't exist already was kind of a given. Any reason why that would be undesirable?

@Fyorl Fyorl added the strategic Requires sign-off from a core Foundry VTT developer before merge. label Apr 7, 2026
@Aioros Aioros force-pushed the encounter-placement-combat branch from 48c0796 to 01d9335 Compare April 8, 2026 13:25
@Aioros
Copy link
Copy Markdown
Contributor Author

Aioros commented Apr 8, 2026

The updated branch uses a setting as suggested (and it's quite simpler as a result). It still creates the combat if it doesn't already exist, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium strategic Requires sign-off from a core Foundry VTT developer before merge. system: canvas Vision modes and scene interaction ux User experience related features or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Added functionality for placing tokens from Encounter Token

4 participants