Add cloud connection and send server info message to connected clients#826
Open
Add cloud connection and send server info message to connected clients#826
Conversation
- Updated the `connect_session` method to return both the `CloudSession` and the `UnboundedReceiver<RoomEvent>`. - Modified the `run` method to handle the new return type and pass the room events to `listen_for_room_events`. - Removed the `room_events` field from `CloudSession` as it is now managed externally. - Adjusted related methods to accommodate these changes, ensuring proper handling of room events during the session lifecycle.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…esn't work anymore with livekit
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Everything is behind the unused agent (now renamed cloud feature), so I think we don't have backwards compatibility concerns, nor does merging this tie our hands or introduce risk of breaking user code.
This PR adds a CloudConnection and related types. It connects to the livekit room, listens for participants joining, and sends the server info message.
Untested, other than it runs and connects to livekit successfully. It needs the auth and device beacon to be able to test this in the app.
Mostly this is an adaption / simplification of code from our agent prototype.
The Dockerfiles and CI builds need a LOT of TLC to get things working with LiveKit and the libwebrtc crate and C++ compiling that it does, I'm in the process of splitting that work out here: #832