Python example for mcap using RangedPlayback#862
Open
ericmlujan wants to merge 5 commits intoeric/new-mcap-examplefrom
Open
Python example for mcap using RangedPlayback#862ericmlujan wants to merge 5 commits intoeric/new-mcap-examplefrom
ericmlujan wants to merge 5 commits intoeric/new-mcap-examplefrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| def _clamp_speed(speed: float) -> float: | ||
| if not (speed >= _MIN_PLAYBACK_SPEED): # handles NaN/inf | ||
| return _MIN_PLAYBACK_SPEED | ||
| return speed |
There was a problem hiding this comment.
Positive infinity speed causes crash in time calculations
Low Severity
The _clamp_speed function handles NaN and negative infinity by clamping to _MIN_PLAYBACK_SPEED, but positive infinity passes through unchanged since float('inf') >= 0.01 evaluates to True. When positive infinity is used as the speed, calculations like int(elapsed_wall_ns * self._speed) in TimeTracker._current_log_time() will raise an OverflowError because int(float('inf')) is not allowed in Python.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
RangedPlaybackcapabilityDocs
Description
Add a Python example using the RangedPlayback websocket capability to load and play back an mcap file. This example introduces an annotated
PlaybackSourceABC, which others can pattern match to when implementing their own loaders for custom data formats.This PR ports #859.