Conversation
- rename messages which were previously called schemas as messages. Items which are schemas are still referred to as schemas. - Both the messages modules and schemas modules are present. Using the old name will generate a deprecation message suggesting the new name. - At some later (TBD) date the deprecated (old schema labels) should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
The messages types from foxglove::schemas have been moved to foxglove::messages for each language interface. Using the prior module name will still work, but will generate a deprecation warning.
Docs
Code examples and in-code docs have been updated.
Description
rename messages which were previously called schemas as messages. Items which are schemas are
still referred to as schemas.
Both the messages modules and schemas modules are present. Using the old name will generate a
deprecation message suggesting the new name.
At some later date the deprecated (old schema labels) should be removed.