Skip to content

add service account properly#142

Merged
james-rms merged 2 commits intomainfrom
jrms/query-service-service-account-broken
Oct 1, 2025
Merged

add service account properly#142
james-rms merged 2 commits intomainfrom
jrms/query-service-service-account-broken

Conversation

@james-rms
Copy link
Contributor

@james-rms james-rms commented Oct 1, 2025

Changelog

  • primary site: fixed a bug introduced in v0.0.76 where the query service service account object not be created if enabled.

Docs

None.

Description

it looks like when renaming the stream service to query service, I didn't properly namespace the values used in the query-service serviceaccount template.

Testing

  • rendered template using values that include a service account, verify that the required service account + annotations are created.

Fixes: FIRE-159

BeforeAfter

@james-rms james-rms force-pushed the jrms/query-service-service-account-broken branch from 23b88ef to 53167b5 Compare October 1, 2025 00:49
@james-rms james-rms requested a review from sofuture October 1, 2025 00:51
@linear
Copy link

linear bot commented Oct 1, 2025

@james-rms james-rms merged commit eb7b07d into main Oct 1, 2025
2 checks passed
@james-rms james-rms deleted the jrms/query-service-service-account-broken branch October 1, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants