Skip to content

refactor: bump MSRV to v1.88.0 and use if-let-chains#1035

Open
MrCroxx wants to merge 4 commits intomainfrom
xx/if-let-chains
Open

refactor: bump MSRV to v1.88.0 and use if-let-chains#1035
MrCroxx wants to merge 4 commits intomainfrom
xx/if-let-chains

Conversation

@MrCroxx
Copy link
Member

@MrCroxx MrCroxx commented Jun 27, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

AS IS

But hold it for our dependents..

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

MrCroxx added 3 commits June 27, 2025 12:02
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added this to the v0.18 milestone Jun 27, 2025
@MrCroxx MrCroxx self-assigned this Jun 27, 2025
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/eviction/lru.rs 0.00% 4 Missing ⚠️
foyer-storage/src/large/generic.rs 0.00% 2 Missing ⚠️
foyer-storage/src/large/reclaimer.rs 0.00% 2 Missing ⚠️
foyer-storage/src/large/serde.rs 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-bench/src/analyze.rs 97.90% <ø> (+97.90%) ⬆️
foyer-bench/src/exporter.rs 0.00% <ø> (ø)
foyer-bench/src/main.rs 68.19% <100.00%> (+68.19%) ⬆️
foyer-common/src/bits.rs 65.51% <ø> (ø)
foyer-common/src/future.rs 100.00% <ø> (ø)
foyer-common/src/rate.rs 98.11% <ø> (ø)
foyer-common/src/rated_ticket.rs 100.00% <ø> (ø)
foyer-common/src/utils/range.rs 0.00% <ø> (ø)
foyer-memory/src/cache.rs 78.79% <ø> (ø)
foyer-memory/src/eviction/fifo.rs 100.00% <ø> (ø)
... and 36 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCroxx MrCroxx modified the milestones: v0.18, Planning Jul 29, 2025
@MrCroxx MrCroxx force-pushed the main branch 2 times, most recently from 3f7f53f to c009129 Compare September 12, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant