[WIP] refactor: use trait to split tokio and madsim-tokio#1220
[WIP] refactor: use trait to split tokio and madsim-tokio#1220
Conversation
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
|
Too many conflicts. Will open another PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: impl Into<Cow<'static, str>>, | ||
| memory: Cache<K, V, S, P>, | ||
| executor: ExecutorEnum, | ||
| metrics: Arc<Metrics>, | ||
| ) -> Self { |
There was a problem hiding this comment.
The constructor now takes four arguments (name, memory, executor, metrics), but several call sites still use the old three-argument form (e.g., foyer-storage/tests/storage_fuzzy_test.rs:110, foyer/src/hybrid/builder.rs:233, foyer-bench/src/main.rs:658). Building the workspace will fail with “expected 4 arguments, found 3” until those callers provide an ExecutorEnum.
Useful? React with 👍 / 👎.
| mod filter; | ||
| mod io; |
There was a problem hiding this comment.
The storage crate no longer declares a runtime module or RuntimeOptions, but downstream code still imports and uses them (e.g., foyer/src/prelude.rs:43 reexports Runtime/RuntimeOptions, foyer/src/hybrid/builder.rs configures runtime options, and examples/hybrid_full.rs constructs RuntimeOptions). With these symbols removed here, the workspace currently fails to compile with unresolved import/type errors.
Useful? React with 👍 / 👎.
1 participant
What's changed and what's your intention?
WIP...
TODO: Fulfill PR message.
Checklist
cargo x(orcargo x --fastinstead if the old tests are not modified) in my local environment.Related issues or PRs (optional)