WhatsApp Dial Option #41
Conversation
There was a problem hiding this comment.
Hey @nathanielajayi7 , I sincerely appreciate your work here.
Unfortunately I do have some concerns about GDPR and other international laws when it comes to the way you're checking WhatsApp availability for a specific contact and I think we might need to explore other options. Therefore, while I thank you for your work, I'm not very confident about merging your PR at this moment.
I have also put a bunch of other comments that you might want to check.
Please let me know if you have any questions.
Thanks!
| @@ -11,6 +11,6 @@ | |||
| <entry name="!?*.kt" /> | |||
| <entry name="!?*.clj" /> | |||
| </wildcardResourcePatterns> | |||
| <bytecodeTargetLevel target="1.8" /> | |||
| <bytecodeTargetLevel target="11" /> | |||
There was a problem hiding this comment.
Is this change actually needed for the feature?
| @@ -45,7 +46,7 @@ | |||
| </value> | |||
| </option> | |||
| </component> | |||
| <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" default="true" project-jdk-name="1.8" project-jdk-type="JavaSDK"> | |||
| <component name="ProjectRootManager" version="2" languageLevel="JDK_11" project-jdk-name="1.8" project-jdk-type="JavaSDK"> | |||
There was a problem hiding this comment.
Do we really need to change this for this feature?
There was a problem hiding this comment.
I don't think this is related to the feature.
| <package | ||
| android:name="com.whatsapp" | ||
| /> |
There was a problem hiding this comment.
Could you please make this a single line?
| <receiver android:name=".appwidget.DirectCallWidgetProvider"> | ||
| <receiver | ||
| android:name=".appwidget.DirectCallWidgetProvider" | ||
| android:exported="true"> |
There was a problem hiding this comment.
Why do we need to export this receiver?
|
|
||
|
|
||
| @SuppressLint("Range") | ||
| private fun hasWhatsapp(contactId:String, context: Context):String? { |
There was a problem hiding this comment.
I have concerns about GPDR on this.
There was a problem hiding this comment.
Please remove this one, the widget is already resizable.
| @@ -23,6 +23,7 @@ import android.net.Uri | |||
| data class Contact( | |||
| val displayName: String, | |||
| val photoUri: Uri?, | |||
| val contactId: String?, | |||
There was a problem hiding this comment.
This one is WhatsApp-specific and shouldn't be part of this class.
| val contactId: String?, |
| @@ -50,6 +52,7 @@ class ContactRepository( | |||
| return@withContext Contact( | |||
| getString(Contacts.DISPLAY_NAME) ?: "", | |||
| getUri(Contacts.PHOTO_URI), | |||
| getString(cursor.getColumnIndexOrThrow(ContactsContract.PhoneLookup._ID)), | |||
There was a problem hiding this comment.
I don't think we should risk getting an exception here.
|
Hey there, @fpalonso Nice to see you're still active! I honestly didn't think you'd still see this PR. Most of the latest fixes were last minute workarounds to get something done for my grandma (which is why I discovered your repo anyway lol) I'll take every comment into consideration and work on them. If there are GPDR concerns about this feature, maybe it's also best it's forgone. I'll do a little more digging and give you feedback |
|
Hey @nathanielajayi7 , sounds amazing, thanks for understanding. |
This PR gives users the option to add WhatsApp dial feature to the contact